users_test.go 24 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872
  1. // Copyright 2020 The Gogs Authors. All rights reserved.
  2. // Use of this source code is governed by a MIT-style
  3. // license that can be found in the LICENSE file.
  4. package db
  5. import (
  6. "context"
  7. "fmt"
  8. "os"
  9. "path/filepath"
  10. "strings"
  11. "testing"
  12. "time"
  13. "github.com/stretchr/testify/assert"
  14. "github.com/stretchr/testify/require"
  15. "gorm.io/gorm"
  16. "gogs.io/gogs/internal/auth"
  17. "gogs.io/gogs/internal/conf"
  18. "gogs.io/gogs/internal/dbtest"
  19. "gogs.io/gogs/internal/dbutil"
  20. "gogs.io/gogs/internal/errutil"
  21. "gogs.io/gogs/internal/osutil"
  22. "gogs.io/gogs/internal/repoutil"
  23. "gogs.io/gogs/internal/userutil"
  24. "gogs.io/gogs/public"
  25. )
  26. func TestUser_BeforeCreate(t *testing.T) {
  27. now := time.Now()
  28. db := &gorm.DB{
  29. Config: &gorm.Config{
  30. SkipDefaultTransaction: true,
  31. NowFunc: func() time.Time {
  32. return now
  33. },
  34. },
  35. }
  36. t.Run("CreatedUnix has been set", func(t *testing.T) {
  37. user := &User{
  38. CreatedUnix: 1,
  39. }
  40. _ = user.BeforeCreate(db)
  41. assert.Equal(t, int64(1), user.CreatedUnix)
  42. assert.Equal(t, int64(0), user.UpdatedUnix)
  43. })
  44. t.Run("CreatedUnix has not been set", func(t *testing.T) {
  45. user := &User{}
  46. _ = user.BeforeCreate(db)
  47. assert.Equal(t, db.NowFunc().Unix(), user.CreatedUnix)
  48. assert.Equal(t, db.NowFunc().Unix(), user.UpdatedUnix)
  49. })
  50. }
  51. func TestUser_AfterFind(t *testing.T) {
  52. now := time.Now()
  53. db := &gorm.DB{
  54. Config: &gorm.Config{
  55. SkipDefaultTransaction: true,
  56. NowFunc: func() time.Time {
  57. return now
  58. },
  59. },
  60. }
  61. user := &User{
  62. CreatedUnix: now.Unix(),
  63. UpdatedUnix: now.Unix(),
  64. }
  65. _ = user.AfterFind(db)
  66. assert.Equal(t, user.CreatedUnix, user.Created.Unix())
  67. assert.Equal(t, user.UpdatedUnix, user.Updated.Unix())
  68. }
  69. func TestUsers(t *testing.T) {
  70. if testing.Short() {
  71. t.Skip()
  72. }
  73. t.Parallel()
  74. tables := []interface{}{new(User), new(EmailAddress), new(Repository), new(Follow), new(PullRequest)}
  75. db := &users{
  76. DB: dbtest.NewDB(t, "users", tables...),
  77. }
  78. for _, tc := range []struct {
  79. name string
  80. test func(t *testing.T, db *users)
  81. }{
  82. {"Authenticate", usersAuthenticate},
  83. {"ChangeUsername", usersChangeUsername},
  84. {"Count", usersCount},
  85. {"Create", usersCreate},
  86. {"DeleteCustomAvatar", usersDeleteCustomAvatar},
  87. {"GetByEmail", usersGetByEmail},
  88. {"GetByID", usersGetByID},
  89. {"GetByUsername", usersGetByUsername},
  90. {"HasForkedRepository", usersHasForkedRepository},
  91. {"IsUsernameUsed", usersIsUsernameUsed},
  92. {"List", usersList},
  93. {"ListFollowers", usersListFollowers},
  94. {"ListFollowings", usersListFollowings},
  95. {"Update", usersUpdate},
  96. {"UseCustomAvatar", usersUseCustomAvatar},
  97. } {
  98. t.Run(tc.name, func(t *testing.T) {
  99. t.Cleanup(func() {
  100. err := clearTables(t, db.DB, tables...)
  101. require.NoError(t, err)
  102. })
  103. tc.test(t, db)
  104. })
  105. if t.Failed() {
  106. break
  107. }
  108. }
  109. }
  110. func usersAuthenticate(t *testing.T, db *users) {
  111. ctx := context.Background()
  112. password := "pa$$word"
  113. alice, err := db.Create(ctx, "alice", "[email protected]",
  114. CreateUserOptions{
  115. Password: password,
  116. },
  117. )
  118. require.NoError(t, err)
  119. t.Run("user not found", func(t *testing.T) {
  120. _, err := db.Authenticate(ctx, "bob", password, -1)
  121. wantErr := auth.ErrBadCredentials{Args: map[string]interface{}{"login": "bob"}}
  122. assert.Equal(t, wantErr, err)
  123. })
  124. t.Run("invalid password", func(t *testing.T) {
  125. _, err := db.Authenticate(ctx, alice.Name, "bad_password", -1)
  126. wantErr := auth.ErrBadCredentials{Args: map[string]interface{}{"login": alice.Name, "userID": alice.ID}}
  127. assert.Equal(t, wantErr, err)
  128. })
  129. t.Run("via email and password", func(t *testing.T) {
  130. user, err := db.Authenticate(ctx, alice.Email, password, -1)
  131. require.NoError(t, err)
  132. assert.Equal(t, alice.Name, user.Name)
  133. })
  134. t.Run("via username and password", func(t *testing.T) {
  135. user, err := db.Authenticate(ctx, alice.Name, password, -1)
  136. require.NoError(t, err)
  137. assert.Equal(t, alice.Name, user.Name)
  138. })
  139. t.Run("login source mismatch", func(t *testing.T) {
  140. _, err := db.Authenticate(ctx, alice.Email, password, 1)
  141. gotErr := fmt.Sprintf("%v", err)
  142. wantErr := ErrLoginSourceMismatch{args: map[string]interface{}{"actual": 0, "expect": 1}}.Error()
  143. assert.Equal(t, wantErr, gotErr)
  144. })
  145. t.Run("via login source", func(t *testing.T) {
  146. mockLoginSources := NewMockLoginSourcesStore()
  147. mockLoginSources.GetByIDFunc.SetDefaultHook(func(ctx context.Context, id int64) (*LoginSource, error) {
  148. mockProvider := NewMockProvider()
  149. mockProvider.AuthenticateFunc.SetDefaultReturn(&auth.ExternalAccount{}, nil)
  150. s := &LoginSource{
  151. IsActived: true,
  152. Provider: mockProvider,
  153. }
  154. return s, nil
  155. })
  156. setMockLoginSourcesStore(t, mockLoginSources)
  157. bob, err := db.Create(ctx, "bob", "[email protected]",
  158. CreateUserOptions{
  159. Password: password,
  160. LoginSource: 1,
  161. },
  162. )
  163. require.NoError(t, err)
  164. user, err := db.Authenticate(ctx, bob.Email, password, 1)
  165. require.NoError(t, err)
  166. assert.Equal(t, bob.Name, user.Name)
  167. })
  168. t.Run("new user via login source", func(t *testing.T) {
  169. mockLoginSources := NewMockLoginSourcesStore()
  170. mockLoginSources.GetByIDFunc.SetDefaultHook(func(ctx context.Context, id int64) (*LoginSource, error) {
  171. mockProvider := NewMockProvider()
  172. mockProvider.AuthenticateFunc.SetDefaultReturn(
  173. &auth.ExternalAccount{
  174. Name: "cindy",
  175. Email: "[email protected]",
  176. },
  177. nil,
  178. )
  179. s := &LoginSource{
  180. IsActived: true,
  181. Provider: mockProvider,
  182. }
  183. return s, nil
  184. })
  185. setMockLoginSourcesStore(t, mockLoginSources)
  186. user, err := db.Authenticate(ctx, "cindy", password, 1)
  187. require.NoError(t, err)
  188. assert.Equal(t, "cindy", user.Name)
  189. user, err = db.GetByUsername(ctx, "cindy")
  190. require.NoError(t, err)
  191. assert.Equal(t, "[email protected]", user.Email)
  192. })
  193. }
  194. func usersChangeUsername(t *testing.T, db *users) {
  195. ctx := context.Background()
  196. alice, err := db.Create(
  197. ctx,
  198. "alice",
  199. "[email protected]",
  200. CreateUserOptions{
  201. Activated: true,
  202. },
  203. )
  204. require.NoError(t, err)
  205. t.Run("name not allowed", func(t *testing.T) {
  206. err := db.ChangeUsername(ctx, alice.ID, "-")
  207. wantErr := ErrNameNotAllowed{
  208. args: errutil.Args{
  209. "reason": "reserved",
  210. "name": "-",
  211. },
  212. }
  213. assert.Equal(t, wantErr, err)
  214. })
  215. t.Run("name already exists", func(t *testing.T) {
  216. bob, err := db.Create(
  217. ctx,
  218. "bob",
  219. "[email protected]",
  220. CreateUserOptions{
  221. Activated: true,
  222. },
  223. )
  224. require.NoError(t, err)
  225. err = db.ChangeUsername(ctx, alice.ID, bob.Name)
  226. wantErr := ErrUserAlreadyExist{
  227. args: errutil.Args{
  228. "name": bob.Name,
  229. },
  230. }
  231. assert.Equal(t, wantErr, err)
  232. })
  233. tempRepositoryRoot := filepath.Join(os.TempDir(), "usersChangeUsername-tempRepositoryRoot")
  234. conf.SetMockRepository(
  235. t,
  236. conf.RepositoryOpts{
  237. Root: tempRepositoryRoot,
  238. },
  239. )
  240. err = os.RemoveAll(tempRepositoryRoot)
  241. require.NoError(t, err)
  242. defer func() { _ = os.RemoveAll(tempRepositoryRoot) }()
  243. tempServerAppDataPath := filepath.Join(os.TempDir(), "usersChangeUsername-tempServerAppDataPath")
  244. conf.SetMockServer(
  245. t,
  246. conf.ServerOpts{
  247. AppDataPath: tempServerAppDataPath,
  248. },
  249. )
  250. err = os.RemoveAll(tempServerAppDataPath)
  251. require.NoError(t, err)
  252. defer func() { _ = os.RemoveAll(tempServerAppDataPath) }()
  253. repo, err := NewReposStore(db.DB).Create(
  254. ctx,
  255. alice.ID,
  256. CreateRepoOptions{
  257. Name: "test-repo-1",
  258. },
  259. )
  260. require.NoError(t, err)
  261. // TODO: Use PullRequests.Create to replace SQL hack when the method is available.
  262. err = db.Exec(`INSERT INTO pull_request (head_user_name) VALUES (?)`, alice.Name).Error
  263. require.NoError(t, err)
  264. err = db.Model(&User{}).Where("id = ?", alice.ID).Update("updated_unix", 0).Error
  265. require.NoError(t, err)
  266. err = os.MkdirAll(repoutil.UserPath(alice.Name), os.ModePerm)
  267. require.NoError(t, err)
  268. err = os.MkdirAll(repoutil.RepositoryLocalPath(repo.ID), os.ModePerm)
  269. require.NoError(t, err)
  270. err = os.MkdirAll(repoutil.RepositoryLocalWikiPath(repo.ID), os.ModePerm)
  271. require.NoError(t, err)
  272. // Make sure mock data is set up correctly
  273. // TODO: Use PullRequests.GetByID to replace SQL hack when the method is available.
  274. var headUserName string
  275. err = db.Model(&PullRequest{}).Select("head_user_name").Row().Scan(&headUserName)
  276. require.NoError(t, err)
  277. assert.Equal(t, headUserName, alice.Name)
  278. var updatedUnix int64
  279. err = db.Model(&User{}).Select("updated_unix").Where("id = ?", alice.ID).Row().Scan(&updatedUnix)
  280. require.NoError(t, err)
  281. assert.Equal(t, int64(0), updatedUnix)
  282. assert.True(t, osutil.IsExist(repoutil.UserPath(alice.Name)))
  283. assert.True(t, osutil.IsExist(repoutil.RepositoryLocalPath(repo.ID)))
  284. assert.True(t, osutil.IsExist(repoutil.RepositoryLocalWikiPath(repo.ID)))
  285. const newUsername = "alice-new"
  286. err = db.ChangeUsername(ctx, alice.ID, newUsername)
  287. require.NoError(t, err)
  288. // TODO: Use PullRequests.GetByID to replace SQL hack when the method is available.
  289. err = db.Model(&PullRequest{}).Select("head_user_name").Row().Scan(&headUserName)
  290. require.NoError(t, err)
  291. assert.Equal(t, headUserName, newUsername)
  292. assert.True(t, osutil.IsExist(repoutil.UserPath(newUsername)))
  293. assert.False(t, osutil.IsExist(repoutil.UserPath(alice.Name)))
  294. assert.False(t, osutil.IsExist(repoutil.RepositoryLocalPath(repo.ID)))
  295. assert.False(t, osutil.IsExist(repoutil.RepositoryLocalWikiPath(repo.ID)))
  296. alice, err = db.GetByID(ctx, alice.ID)
  297. require.NoError(t, err)
  298. assert.Equal(t, newUsername, alice.Name)
  299. assert.Equal(t, db.NowFunc().Unix(), alice.UpdatedUnix)
  300. // Change the cases of the username should just be fine
  301. err = db.ChangeUsername(ctx, alice.ID, strings.ToUpper(newUsername))
  302. require.NoError(t, err)
  303. alice, err = db.GetByID(ctx, alice.ID)
  304. require.NoError(t, err)
  305. assert.Equal(t, strings.ToUpper(newUsername), alice.Name)
  306. }
  307. func usersCount(t *testing.T, db *users) {
  308. ctx := context.Background()
  309. // Has no user initially
  310. got := db.Count(ctx)
  311. assert.Equal(t, int64(0), got)
  312. _, err := db.Create(ctx, "alice", "[email protected]", CreateUserOptions{})
  313. require.NoError(t, err)
  314. got = db.Count(ctx)
  315. assert.Equal(t, int64(1), got)
  316. // Create an organization shouldn't count
  317. // TODO: Use Orgs.Create to replace SQL hack when the method is available.
  318. org1, err := db.Create(ctx, "org1", "[email protected]", CreateUserOptions{})
  319. require.NoError(t, err)
  320. err = db.Exec(
  321. dbutil.Quote("UPDATE %s SET type = ? WHERE id = ?", "user"),
  322. UserTypeOrganization, org1.ID,
  323. ).Error
  324. require.NoError(t, err)
  325. got = db.Count(ctx)
  326. assert.Equal(t, int64(1), got)
  327. }
  328. func usersCreate(t *testing.T, db *users) {
  329. ctx := context.Background()
  330. alice, err := db.Create(
  331. ctx,
  332. "alice",
  333. "[email protected]",
  334. CreateUserOptions{
  335. Activated: true,
  336. },
  337. )
  338. require.NoError(t, err)
  339. t.Run("name not allowed", func(t *testing.T) {
  340. _, err := db.Create(ctx, "-", "", CreateUserOptions{})
  341. wantErr := ErrNameNotAllowed{
  342. args: errutil.Args{
  343. "reason": "reserved",
  344. "name": "-",
  345. },
  346. }
  347. assert.Equal(t, wantErr, err)
  348. })
  349. t.Run("name already exists", func(t *testing.T) {
  350. _, err := db.Create(ctx, alice.Name, "", CreateUserOptions{})
  351. wantErr := ErrUserAlreadyExist{
  352. args: errutil.Args{
  353. "name": alice.Name,
  354. },
  355. }
  356. assert.Equal(t, wantErr, err)
  357. })
  358. t.Run("email already exists", func(t *testing.T) {
  359. _, err := db.Create(ctx, "bob", alice.Email, CreateUserOptions{})
  360. wantErr := ErrEmailAlreadyUsed{
  361. args: errutil.Args{
  362. "email": alice.Email,
  363. },
  364. }
  365. assert.Equal(t, wantErr, err)
  366. })
  367. user, err := db.GetByUsername(ctx, alice.Name)
  368. require.NoError(t, err)
  369. assert.Equal(t, db.NowFunc().Format(time.RFC3339), user.Created.UTC().Format(time.RFC3339))
  370. assert.Equal(t, db.NowFunc().Format(time.RFC3339), user.Updated.UTC().Format(time.RFC3339))
  371. }
  372. func usersDeleteCustomAvatar(t *testing.T, db *users) {
  373. ctx := context.Background()
  374. alice, err := db.Create(ctx, "alice", "[email protected]", CreateUserOptions{})
  375. require.NoError(t, err)
  376. avatar, err := public.Files.ReadFile("img/avatar_default.png")
  377. require.NoError(t, err)
  378. avatarPath := userutil.CustomAvatarPath(alice.ID)
  379. _ = os.Remove(avatarPath)
  380. defer func() { _ = os.Remove(avatarPath) }()
  381. err = db.UseCustomAvatar(ctx, alice.ID, avatar)
  382. require.NoError(t, err)
  383. // Make sure avatar is saved and the user flag is updated.
  384. got := osutil.IsFile(avatarPath)
  385. assert.True(t, got)
  386. alice, err = db.GetByID(ctx, alice.ID)
  387. require.NoError(t, err)
  388. assert.True(t, alice.UseCustomAvatar)
  389. // Delete avatar should remove the file and revert the user flag.
  390. err = db.DeleteCustomAvatar(ctx, alice.ID)
  391. require.NoError(t, err)
  392. got = osutil.IsFile(avatarPath)
  393. assert.False(t, got)
  394. alice, err = db.GetByID(ctx, alice.ID)
  395. require.NoError(t, err)
  396. assert.False(t, alice.UseCustomAvatar)
  397. }
  398. func usersGetByEmail(t *testing.T, db *users) {
  399. ctx := context.Background()
  400. t.Run("empty email", func(t *testing.T) {
  401. _, err := db.GetByEmail(ctx, "")
  402. wantErr := ErrUserNotExist{args: errutil.Args{"email": ""}}
  403. assert.Equal(t, wantErr, err)
  404. })
  405. t.Run("ignore organization", func(t *testing.T) {
  406. // TODO: Use Orgs.Create to replace SQL hack when the method is available.
  407. org, err := db.Create(ctx, "gogs", "[email protected]", CreateUserOptions{})
  408. require.NoError(t, err)
  409. err = db.Model(&User{}).Where("id", org.ID).UpdateColumn("type", UserTypeOrganization).Error
  410. require.NoError(t, err)
  411. _, err = db.GetByEmail(ctx, org.Email)
  412. wantErr := ErrUserNotExist{args: errutil.Args{"email": org.Email}}
  413. assert.Equal(t, wantErr, err)
  414. })
  415. t.Run("by primary email", func(t *testing.T) {
  416. alice, err := db.Create(ctx, "alice", "[email protected]", CreateUserOptions{})
  417. require.NoError(t, err)
  418. _, err = db.GetByEmail(ctx, alice.Email)
  419. wantErr := ErrUserNotExist{args: errutil.Args{"email": alice.Email}}
  420. assert.Equal(t, wantErr, err)
  421. // Mark user as activated
  422. // TODO: Use UserEmails.Verify to replace SQL hack when the method is available.
  423. err = db.Model(&User{}).Where("id", alice.ID).UpdateColumn("is_active", true).Error
  424. require.NoError(t, err)
  425. user, err := db.GetByEmail(ctx, alice.Email)
  426. require.NoError(t, err)
  427. assert.Equal(t, alice.Name, user.Name)
  428. })
  429. t.Run("by secondary email", func(t *testing.T) {
  430. bob, err := db.Create(ctx, "bob", "[email protected]", CreateUserOptions{})
  431. require.NoError(t, err)
  432. // TODO: Use UserEmails.Create to replace SQL hack when the method is available.
  433. email2 := "[email protected]"
  434. err = db.Exec(`INSERT INTO email_address (uid, email) VALUES (?, ?)`, bob.ID, email2).Error
  435. require.NoError(t, err)
  436. _, err = db.GetByEmail(ctx, email2)
  437. wantErr := ErrUserNotExist{args: errutil.Args{"email": email2}}
  438. assert.Equal(t, wantErr, err)
  439. // TODO: Use UserEmails.Verify to replace SQL hack when the method is available.
  440. err = db.Exec(`UPDATE email_address SET is_activated = ? WHERE email = ?`, true, email2).Error
  441. require.NoError(t, err)
  442. user, err := db.GetByEmail(ctx, email2)
  443. require.NoError(t, err)
  444. assert.Equal(t, bob.Name, user.Name)
  445. })
  446. }
  447. func usersGetByID(t *testing.T, db *users) {
  448. ctx := context.Background()
  449. alice, err := db.Create(ctx, "alice", "[email protected]", CreateUserOptions{})
  450. require.NoError(t, err)
  451. user, err := db.GetByID(ctx, alice.ID)
  452. require.NoError(t, err)
  453. assert.Equal(t, alice.Name, user.Name)
  454. _, err = db.GetByID(ctx, 404)
  455. wantErr := ErrUserNotExist{args: errutil.Args{"userID": int64(404)}}
  456. assert.Equal(t, wantErr, err)
  457. }
  458. func usersGetByUsername(t *testing.T, db *users) {
  459. ctx := context.Background()
  460. alice, err := db.Create(ctx, "alice", "[email protected]", CreateUserOptions{})
  461. require.NoError(t, err)
  462. user, err := db.GetByUsername(ctx, alice.Name)
  463. require.NoError(t, err)
  464. assert.Equal(t, alice.Name, user.Name)
  465. _, err = db.GetByUsername(ctx, "bad_username")
  466. wantErr := ErrUserNotExist{args: errutil.Args{"name": "bad_username"}}
  467. assert.Equal(t, wantErr, err)
  468. }
  469. func usersHasForkedRepository(t *testing.T, db *users) {
  470. ctx := context.Background()
  471. has := db.HasForkedRepository(ctx, 1, 1)
  472. assert.False(t, has)
  473. _, err := NewReposStore(db.DB).Create(
  474. ctx,
  475. 1,
  476. CreateRepoOptions{
  477. Name: "repo1",
  478. ForkID: 1,
  479. },
  480. )
  481. require.NoError(t, err)
  482. has = db.HasForkedRepository(ctx, 1, 1)
  483. assert.True(t, has)
  484. }
  485. func usersIsUsernameUsed(t *testing.T, db *users) {
  486. ctx := context.Background()
  487. alice, err := db.Create(ctx, "alice", "[email protected]", CreateUserOptions{})
  488. require.NoError(t, err)
  489. tests := []struct {
  490. name string
  491. username string
  492. excludeUserID int64
  493. want bool
  494. }{
  495. {
  496. name: "no change",
  497. username: alice.Name,
  498. excludeUserID: alice.ID,
  499. want: false,
  500. },
  501. {
  502. name: "change case",
  503. username: strings.ToUpper(alice.Name),
  504. excludeUserID: alice.ID,
  505. want: false,
  506. },
  507. {
  508. name: "not used",
  509. username: "bob",
  510. excludeUserID: alice.ID,
  511. want: false,
  512. },
  513. {
  514. name: "not used when not excluded",
  515. username: "bob",
  516. excludeUserID: 0,
  517. want: false,
  518. },
  519. {
  520. name: "used when not excluded",
  521. username: alice.Name,
  522. excludeUserID: 0,
  523. want: true,
  524. },
  525. }
  526. for _, test := range tests {
  527. t.Run(test.name, func(t *testing.T) {
  528. got := db.IsUsernameUsed(ctx, test.username, test.excludeUserID)
  529. assert.Equal(t, test.want, got)
  530. })
  531. }
  532. }
  533. func usersList(t *testing.T, db *users) {
  534. ctx := context.Background()
  535. alice, err := db.Create(ctx, "alice", "[email protected]", CreateUserOptions{})
  536. require.NoError(t, err)
  537. bob, err := db.Create(ctx, "bob", "[email protected]", CreateUserOptions{})
  538. require.NoError(t, err)
  539. // Create an organization shouldn't count
  540. // TODO: Use Orgs.Create to replace SQL hack when the method is available.
  541. org1, err := db.Create(ctx, "org1", "[email protected]", CreateUserOptions{})
  542. require.NoError(t, err)
  543. err = db.Exec(
  544. dbutil.Quote("UPDATE %s SET type = ? WHERE id = ?", "user"),
  545. UserTypeOrganization, org1.ID,
  546. ).Error
  547. require.NoError(t, err)
  548. got, err := db.List(ctx, 1, 1)
  549. require.NoError(t, err)
  550. require.Len(t, got, 1)
  551. assert.Equal(t, alice.ID, got[0].ID)
  552. got, err = db.List(ctx, 2, 1)
  553. require.NoError(t, err)
  554. require.Len(t, got, 1)
  555. assert.Equal(t, bob.ID, got[0].ID)
  556. got, err = db.List(ctx, 1, 3)
  557. require.NoError(t, err)
  558. require.Len(t, got, 2)
  559. assert.Equal(t, alice.ID, got[0].ID)
  560. assert.Equal(t, bob.ID, got[1].ID)
  561. }
  562. func usersListFollowers(t *testing.T, db *users) {
  563. ctx := context.Background()
  564. john, err := db.Create(ctx, "john", "[email protected]", CreateUserOptions{})
  565. require.NoError(t, err)
  566. got, err := db.ListFollowers(ctx, john.ID, 1, 1)
  567. require.NoError(t, err)
  568. assert.Empty(t, got)
  569. alice, err := db.Create(ctx, "alice", "[email protected]", CreateUserOptions{})
  570. require.NoError(t, err)
  571. bob, err := db.Create(ctx, "bob", "[email protected]", CreateUserOptions{})
  572. require.NoError(t, err)
  573. followsStore := NewFollowsStore(db.DB)
  574. err = followsStore.Follow(ctx, alice.ID, john.ID)
  575. require.NoError(t, err)
  576. err = followsStore.Follow(ctx, bob.ID, john.ID)
  577. require.NoError(t, err)
  578. // First page only has bob
  579. got, err = db.ListFollowers(ctx, john.ID, 1, 1)
  580. require.NoError(t, err)
  581. require.Len(t, got, 1)
  582. assert.Equal(t, bob.ID, got[0].ID)
  583. // Second page only has alice
  584. got, err = db.ListFollowers(ctx, john.ID, 2, 1)
  585. require.NoError(t, err)
  586. require.Len(t, got, 1)
  587. assert.Equal(t, alice.ID, got[0].ID)
  588. }
  589. func usersListFollowings(t *testing.T, db *users) {
  590. ctx := context.Background()
  591. john, err := db.Create(ctx, "john", "[email protected]", CreateUserOptions{})
  592. require.NoError(t, err)
  593. got, err := db.ListFollowers(ctx, john.ID, 1, 1)
  594. require.NoError(t, err)
  595. assert.Empty(t, got)
  596. alice, err := db.Create(ctx, "alice", "[email protected]", CreateUserOptions{})
  597. require.NoError(t, err)
  598. bob, err := db.Create(ctx, "bob", "[email protected]", CreateUserOptions{})
  599. require.NoError(t, err)
  600. followsStore := NewFollowsStore(db.DB)
  601. err = followsStore.Follow(ctx, john.ID, alice.ID)
  602. require.NoError(t, err)
  603. err = followsStore.Follow(ctx, john.ID, bob.ID)
  604. require.NoError(t, err)
  605. // First page only has bob
  606. got, err = db.ListFollowings(ctx, john.ID, 1, 1)
  607. require.NoError(t, err)
  608. require.Len(t, got, 1)
  609. assert.Equal(t, bob.ID, got[0].ID)
  610. // Second page only has alice
  611. got, err = db.ListFollowings(ctx, john.ID, 2, 1)
  612. require.NoError(t, err)
  613. require.Len(t, got, 1)
  614. assert.Equal(t, alice.ID, got[0].ID)
  615. }
  616. func usersUpdate(t *testing.T, db *users) {
  617. ctx := context.Background()
  618. const oldPassword = "Password"
  619. alice, err := db.Create(
  620. ctx,
  621. "alice",
  622. "[email protected]",
  623. CreateUserOptions{
  624. FullName: "FullName",
  625. Password: oldPassword,
  626. LoginSource: 9,
  627. LoginName: "LoginName",
  628. Location: "Location",
  629. Website: "Website",
  630. Activated: false,
  631. Admin: false,
  632. },
  633. )
  634. require.NoError(t, err)
  635. t.Run("update password", func(t *testing.T) {
  636. got := userutil.ValidatePassword(alice.Password, alice.Salt, oldPassword)
  637. require.True(t, got)
  638. newPassword := "NewPassword"
  639. err = db.Update(ctx, alice.ID, UpdateUserOptions{Password: &newPassword})
  640. require.NoError(t, err)
  641. alice, err = db.GetByID(ctx, alice.ID)
  642. require.NoError(t, err)
  643. got = userutil.ValidatePassword(alice.Password, alice.Salt, oldPassword)
  644. assert.False(t, got, "Old password should stop working")
  645. got = userutil.ValidatePassword(alice.Password, alice.Salt, newPassword)
  646. assert.True(t, got, "New password should work")
  647. })
  648. t.Run("update email but already used", func(t *testing.T) {
  649. // todo
  650. })
  651. loginSource := int64(1)
  652. maxRepoCreation := 99
  653. lastRepoVisibility := true
  654. overLimitStr := strings.Repeat("a", 2050)
  655. opts := UpdateUserOptions{
  656. LoginSource: &loginSource,
  657. LoginName: &alice.Name,
  658. FullName: &overLimitStr,
  659. Website: &overLimitStr,
  660. Location: &overLimitStr,
  661. Description: &overLimitStr,
  662. MaxRepoCreation: &maxRepoCreation,
  663. LastRepoVisibility: &lastRepoVisibility,
  664. IsActivated: &lastRepoVisibility,
  665. IsAdmin: &lastRepoVisibility,
  666. AllowGitHook: &lastRepoVisibility,
  667. AllowImportLocal: &lastRepoVisibility,
  668. ProhibitLogin: &lastRepoVisibility,
  669. Avatar: &overLimitStr,
  670. AvatarEmail: &overLimitStr,
  671. }
  672. err = db.Update(ctx, alice.ID, opts)
  673. require.NoError(t, err)
  674. alice, err = db.GetByID(ctx, alice.ID)
  675. require.NoError(t, err)
  676. assertValues := func() {
  677. assert.Equal(t, loginSource, alice.LoginSource)
  678. assert.Equal(t, alice.Name, alice.LoginName)
  679. wantStr255 := strings.Repeat("a", 255)
  680. assert.Equal(t, wantStr255, alice.FullName)
  681. assert.Equal(t, wantStr255, alice.Website)
  682. assert.Equal(t, wantStr255, alice.Location)
  683. assert.Equal(t, wantStr255, alice.Description)
  684. assert.Equal(t, maxRepoCreation, alice.MaxRepoCreation)
  685. assert.Equal(t, lastRepoVisibility, alice.LastRepoVisibility)
  686. assert.Equal(t, lastRepoVisibility, alice.IsActive)
  687. assert.Equal(t, lastRepoVisibility, alice.IsAdmin)
  688. assert.Equal(t, lastRepoVisibility, alice.AllowGitHook)
  689. assert.Equal(t, lastRepoVisibility, alice.AllowImportLocal)
  690. assert.Equal(t, lastRepoVisibility, alice.ProhibitLogin)
  691. wantStr2048 := strings.Repeat("a", 2048)
  692. assert.Equal(t, wantStr2048, alice.Avatar)
  693. assert.Equal(t, wantStr255, alice.AvatarEmail)
  694. }
  695. assertValues()
  696. // Test ignored values
  697. err = db.Update(ctx, alice.ID, UpdateUserOptions{})
  698. require.NoError(t, err)
  699. alice, err = db.GetByID(ctx, alice.ID)
  700. require.NoError(t, err)
  701. assertValues()
  702. }
  703. func usersUseCustomAvatar(t *testing.T, db *users) {
  704. ctx := context.Background()
  705. alice, err := db.Create(ctx, "alice", "[email protected]", CreateUserOptions{})
  706. require.NoError(t, err)
  707. avatar, err := public.Files.ReadFile("img/avatar_default.png")
  708. require.NoError(t, err)
  709. avatarPath := userutil.CustomAvatarPath(alice.ID)
  710. _ = os.Remove(avatarPath)
  711. defer func() { _ = os.Remove(avatarPath) }()
  712. err = db.UseCustomAvatar(ctx, alice.ID, avatar)
  713. require.NoError(t, err)
  714. // Make sure avatar is saved and the user flag is updated.
  715. got := osutil.IsFile(avatarPath)
  716. assert.True(t, got)
  717. alice, err = db.GetByID(ctx, alice.ID)
  718. require.NoError(t, err)
  719. assert.True(t, alice.UseCustomAvatar)
  720. }
  721. func TestIsUsernameAllowed(t *testing.T) {
  722. for name := range reservedUsernames {
  723. t.Run(name, func(t *testing.T) {
  724. assert.True(t, IsErrNameNotAllowed(isUsernameAllowed(name)))
  725. })
  726. }
  727. for _, pattern := range reservedUsernamePatterns {
  728. t.Run(pattern, func(t *testing.T) {
  729. username := strings.ReplaceAll(pattern, "*", "alice")
  730. assert.True(t, IsErrNameNotAllowed(isUsernameAllowed(username)))
  731. })
  732. }
  733. }